You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for contributing to the Docker-Selenium project! A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes#2559
By default, it is present in the generated TOML config file, with no CLI option to avoid unexpected higher precedence value taking effect.
Motivation and Context
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
The session-timeout value is now being written without quotes, which changes its type from string to number in the TOML file. Verify this change is compatible with how Selenium reads this configuration.
Removing SE_NODE_SESSION_TIMEOUT handling could break existing deployments that rely on this environment variable. Consider deprecation notice or backward compatibility.
if [ !-z"$SE_NODE_ENABLE_MANAGED_DOWNLOADS" ];then
append_se_opts "--enable-managed-downloads""${SE_NODE_ENABLE_MANAGED_DOWNLOADS}"fi
+if [[ -z "${SE_NODE_SESSION_TIMEOUT}" ]] || ! [[ "${SE_NODE_SESSION_TIMEOUT}" =~ ^[0-9]+$ ]]; then+ echo "SE_NODE_SESSION_TIMEOUT not set or invalid, using default value" 1>&2+ SE_NODE_SESSION_TIMEOUT=300+fi
echo "session-timeout = ${SE_NODE_SESSION_TIMEOUT}" >>"$FILENAME"
Apply this suggestion
Suggestion importance[1-10]: 8
Why: The suggestion adds crucial input validation for SE_NODE_SESSION_TIMEOUT, preventing potential configuration errors by ensuring the variable exists and contains a valid numeric value, with a sensible default fallback.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #2559
By default, it is present in the generated TOML config file, with no CLI option to avoid unexpected higher precedence value taking effect.
Motivation and Context
Types of changes
Checklist
PR Type
Bug fix, Enhancement
Description
Unified handling of
session-timeoutconfiguration in TOML files.Removed redundant
session-timeoutenvironment variable handling instart-selenium-node.sh.Adjusted TOML file generation to ensure proper formatting for
session-timeout.Improved consistency in configuration handling across Node and Standalone setups.
Changes walkthrough 📝
start-selenium-node.sh
Removed redundant `session-timeout` environment variable handlingNodeBase/start-selenium-node.sh
SE_NODE_SESSION_TIMEOUTenvironmentvariable.
session-timeout.generate_config
Fixed `session-timeout` formatting in TOML generationNodeBase/generate_config
session-timeoutentry to remove unnecessary quotes.generate_config
Corrected `session-timeout` formatting in Standalone TOML generationStandalone/generate_config
session-timeoutentry to remove unnecessary quotes.